Copilot commented on code in PR #4098:
URL: https://github.com/apache/solr/pull/4098#discussion_r2765856586
##########
solr/modules/gcs-repository/build.gradle:
##########
@@ -41,7 +41,14 @@ dependencies {
implementation libs.google.auth.credentials
implementation libs.google.cloud.core
implementation libs.google.cloud.corehttp
- implementation libs.google.cloud.storage
+ implementation(libs.google.cloud.storage) {
+ exclude group: 'io.grpc', module: 'grpc-opentelemetry'
+ exclude group: 'com.google.cloud.opentelemetry', module: 'exporter-metrics'
+ exclude group: 'com.google.cloud', module: 'google-cloud-monitoring'
+ exclude group: 'com.google.api.grpc', module:
'proto-google-cloud-monitoring-v3'
+ exclude group: 'com.google.cloud.opentelemetry', module:
'shared-resourcemapping'
+ exclude group: 'com.google.cloud.opentelemetry', module:
'detector-resources-support'
+ }
Review Comment:
The same set of transitive excludes is duplicated for both
`libs.google.cloud.storage` and `libs.google.cloud.nio`. To reduce the chance
they drift over time (and to make future dependency bumps easier), consider
extracting these excludes into a shared helper/closure or applying them once at
the configuration level for this module.
##########
solr/modules/gcs-repository/gradle.lockfile:
##########
@@ -68,24 +73,23 @@
io.dropwizard.metrics:metrics-jetty12-ee10:4.2.26=jarValidation,testRuntimeClass
io.dropwizard.metrics:metrics-jetty12:4.2.26=jarValidation,testRuntimeClasspath
io.github.eisop:dataflow-errorprone:3.41.0-eisop1=annotationProcessor,errorprone,testAnnotationProcessor
io.github.java-diff-utils:java-diff-utils:4.12=annotationProcessor,errorprone,testAnnotationProcessor
-io.grpc:grpc-alts:1.65.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
-io.grpc:grpc-api:1.65.1=compileClasspath,testCompileClasspath
-io.grpc:grpc-api:1.70.0=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath
-io.grpc:grpc-auth:1.65.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
+io.grpc:grpc-alts:1.76.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
+io.grpc:grpc-api:1.76.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
+io.grpc:grpc-auth:1.76.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
io.grpc:grpc-bom:1.65.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
-io.grpc:grpc-context:1.70.0=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
-io.grpc:grpc-core:1.65.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
-io.grpc:grpc-googleapis:1.65.1=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath
-io.grpc:grpc-grpclb:1.65.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
-io.grpc:grpc-inprocess:1.65.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
-io.grpc:grpc-netty-shaded:1.65.1=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath
-io.grpc:grpc-protobuf-lite:1.65.1=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath
-io.grpc:grpc-protobuf:1.65.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
-io.grpc:grpc-rls:1.65.1=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath
-io.grpc:grpc-services:1.65.1=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath
-io.grpc:grpc-stub:1.65.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
-io.grpc:grpc-util:1.65.1=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath
-io.grpc:grpc-xds:1.65.1=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath
+io.grpc:grpc-context:1.76.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath
Review Comment:
The resolved gRPC artifacts in this lockfile are 1.76.2, but the module
still locks `io.grpc:grpc-bom` at 1.65.1. This defeats BOM-based alignment and
can leave you with an internally inconsistent gRPC set if any dependency relies
on the BOM’s constraints. Consider bumping the gRPC BOM/version catalog entry
to match the resolved gRPC version (or enforcing a single version via an
enforced platform) so all `io.grpc:*` artifacts are aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
