epugh commented on code in PR #4193:
URL: https://github.com/apache/solr/pull/4193#discussion_r2899729172
##########
solr/core/src/java/org/apache/solr/cli/ConfigSetUploadTool.java:
##########
@@ -96,6 +101,22 @@ public void runImpl(CommandLine cli) throws Exception {
+ " to ZooKeeper at "
+ zkHost);
FileTypeMagicUtil.assertConfigSetFolderLegal(confPath);
+ Files.walkFileTree(
Review Comment:
I like adding the validation earlier in the process!
Is there an opportunity to DRY up this block of code in this plus
`ZkConfigSetService`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
