dsmiley commented on code in PR #4193: URL: https://github.com/apache/solr/pull/4193#discussion_r2902222447
########## solr/solrj-zookeeper/src/test/org/apache/solr/common/cloud/TestZkConfigSetService.java: ########## Review Comment: The test was oddly asserting an additional configSet being there. It turns out, this was the "_testconf" that was poisoned with the forbidden file. The previous behavior would leave a partial configset in place despite throwing an error but now the logic is pre-validation, thus we don't create the configset if it has forbidden stuff. An improvement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
