igiguere commented on PR #4078: URL: https://github.com/apache/solr/pull/4078#issuecomment-4025987767
> Hey @igiguere - I left one last round of review. Most of the changes were minor/tedious, so I've taken the liberty of making them myself and pushing to your branch. As such the comments should all be "addressed" and not hugely worth reading, but I still figured I'd leave them as a way to flag what I changed and give a bit of background on the rationale. > > Gonna aim to commit this in the next day or two. Thanks for all your patience and effort on this; exciting to get it merged at long last! Thanks for the fixes, @gerlowskija ! I have read your comments, and resolved the conversations, since it was all fixed. Except for the change in SystemInfoHandler, lines 60+ : that was for back-compatibility of the V1 response, so I think the core info should go back in the V1 System info response. Unless the new CoreInfoHandler added by @epugh is already available in a released version? But, even if that's the case, why unplug everything at once? And note that there's no V2 for CoreInfoHandler. Anyways. You're the committers ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
