gerlowskija commented on PR #4078: URL: https://github.com/apache/solr/pull/4078#issuecomment-4048695180
Excellent - appreciate the double check on those comments. > Except for the change in SystemInfoHandler, lines 60+ : that was for back-compatibility of the V1 response, so I think the core info should go back in the V1 System info response. Can you elaborate about the backcompat break you're seeing there? It's very possible I'm missing something, but my understanding is that even though the code was there to do so, `/admin/info/system` never returned a `core` field in its response because `req.getCore()` is always `null` when the API is accessed at that path. The conditional needed to exist at one point because SystemInfoHandler _used to serve_ `/solr/<coreName>/admin/info` as well. But since that's no longer the case then the conditional in SystemInfoHandler is essentially dead code and can be removed without actually changing the response in any way. What am I missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
