HoustonPutman commented on code in PR #4226:
URL: https://github.com/apache/solr/pull/4226#discussion_r2962167322


##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -1129,8 +1128,8 @@ protected SolrCore(
       SolrFieldCacheBean solrFieldCacheBean = new SolrFieldCacheBean();
       // this is registered at the CONTAINER level because it's not 
core-specific - for now we
       // also register it here for back-compat

Review Comment:
   Perfect, this is the only class that doesn't get closed so it can't actually 
create a child context. Please remove 🙂 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to