dsmiley commented on code in PR #4226:
URL: https://github.com/apache/solr/pull/4226#discussion_r2962780585
##########
solr/core/src/test/org/apache/solr/search/TestThinCache.java:
##########
@@ -99,13 +100,14 @@ public static void setupSolrHome() throws Exception {
String registry = TestUtil.randomSimpleString(random(), 2, 10);
@Test
- public void testSimple() {
+ public void testSimple() throws IOException {
Object cacheScope = new Object();
ThinCache.NodeLevelCache<Object, Integer, String> backing = new
ThinCache.NodeLevelCache<>();
ThinCache<Object, Integer, String> lfuCache = new ThinCache<>();
String lfuCacheName = "lfu_cache";
lfuCache.setBacking(cacheScope, backing);
- SolrMetricsContext solrMetricsContext = new
SolrMetricsContext(metricManager, registry);
+ var solrMetricsContext = new SolrMetricsContext(metricManager, registry);
Review Comment:
I had thought about that. Rather than be super anal about this detail in
tests, which is annoying, I'd rather we configure the ORT mechanism to just log
a one-liner warning when the test fails, since if a test fails then there's
generally a decent chance that *something* is not closed. I'll do a separate
PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
