David Smiley created SOLR-18183:
-----------------------------------
Summary: All EphemeralDirectoryFactory should permit LockType.NONE
Key: SOLR-18183
URL: https://issues.apache.org/jira/browse/SOLR-18183
Project: Solr
Issue Type: Improvement
Reporter: David Smiley
RAMDirectoryFactory and ByteBuffersDirectoryFactory do not permit LockType.NONE
-- but let's support that. MockDirectoryFactory returns NONE with no
complaint. The comment their says it's "unused"... which is curious.
This change is motivated by the experienced observation that
UpdateLog.initTlogDir hard-codes the choice of NONE when it temporarily creates
a a Directory to aid in cleaning up its own files. A test configuring
RAMDirectoryFactory & updateLog configured, doesn't work. Granted, it's
questionable why an UpdateLog is enabled in the first place when an ephemeral
directory is in use. Arguably (separate issue), perhaps the DirectoryFactory
should be responsible for also managing the UpdateLog creation so as to ensure
one isn't created when it's not sensible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
