[ 
https://issues.apache.org/jira/browse/SOLR-16962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069931#comment-18069931
 ] 

David Smiley commented on SOLR-16962:
-------------------------------------

[~magibney] this change introduced a call to [create an instance of the 
Directory from within 
UpdateLog|https://github.com/apache/solr/blob/4f17248195601f8eeca1651f77de46572d851cdb/solr/core/src/java/org/apache/solr/update/UpdateLog.java#L573]
 that previously didn't exist.  It specifically referenced LOCK_TYPE_NONE, 
which makes sense, although annoyingly 
RAMDirectoryFactory/ByteBuffersDirectoryFactory are picky and only accept 
"single".  I filed SOLR-18183 for that.

> updateLog tlog dir location config is silently ignored 
> -------------------------------------------------------
>
>                 Key: SOLR-16962
>                 URL: https://issues.apache.org/jira/browse/SOLR-16962
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 9.2.1, 10.0
>            Reporter: Michael Gibney
>            Assignee: Michael Gibney
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 9.7
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> If you follow the 
> [instructions|https://solr.apache.org/guide/solr/latest/configuration-guide/commits-transaction-logs.html#transaction-log]
>  on configuring a non-default tlog location, solr currently silently ignores 
> explicit configuration and uses the default location 
> {{[instanceDir]/data/tlog/}}.
> Afaict this has been the case for some time, with several layers of faithful 
> refactorings now somewhat obscuring the initial intent.
> This issue proposes to restore the initial intent, and also shore up some of 
> the nuances of handling this (now that the config actually has an effect):
> # resolve relative "dir" spec relative to core instanceDir
> # disallow relative "dir" spec that escapes core instanceDir (e.g., 
> {{dir=../../some_path}})
> # for absolute "dir" spec outside of the core instanceDir, scope the tlog dir 
> by core name



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to