[
https://issues.apache.org/jira/browse/SOLR-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071567#comment-18071567
]
David Smiley commented on SOLR-18188:
-------------------------------------
Overall steps:
(1) A big one is PR #4266, which updates nearly all tests to no longer
*directly* reference Apache import statements, albeit referencing
HttpSolrClient etc. is still allowed. Even some references here get updated
where it made sense to not use it.
(2) SOLR-17968 PR #3829 a big one that renames HttpSolrClientBase to
HttpSolrClient (thus temporarily two HttpSolrClient exists in separate
packages).
(3) Complete the transition...
* Remove the code in org.apache.solr.client.solrj.apache and remove all Apache
dependencies. Some tests won't compile at this point.
* Update test infrastructure to compile (and its internal tests passing) by
using the newer HttpSolrClient and Jetty SolrClient impls.
* Update tests to compile, and tests to pass.
> solr-test-framework: Remove Apache HttpClient usages
> ----------------------------------------------------
>
> Key: SOLR-18188
> URL: https://issues.apache.org/jira/browse/SOLR-18188
> Project: Solr
> Issue Type: Task
> Components: test-framework, Tests
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> As of this writing, the last usages of Apache HttpClient are in Solr's tests.
> This issue aims to remove it completely. But it's a lot of work.
> Some possible steps:
> * Remove tests for our HttpSolrClient & friends (fundamentally based on
> Apache HttpClient)
> * Replace usages of HttpSolrClient.getHttpClient with
> HttpJettySolrClient.getHttpClient
> * Replace usages of HttpSolrClient.getBaseURL by introducing a new base
> client that has this method. Or access similarly from Jetty when easily
> available.
> * of course, stop using HttpSolrClient & friends. Maybe class-by-class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
