janhoy commented on code in PR #3254:
URL: https://github.com/apache/solr/pull/3254#discussion_r3051263835
##########
solr/core/src/java/org/apache/solr/cli/VersionTool.java:
##########
@@ -33,6 +38,16 @@ public String getName() {
@Override
public void runImpl(CommandLine cli) throws Exception {
+ printVersion();
+ }
+
+ @Override
+ public int callTool() throws Exception {
+ printVersion();
+ return 0;
+ }
+
+ private void printVersion() {
CLIO.out("Solr version is: " + SolrVersion.LATEST);
Review Comment:
We talked about whether `solr version` should print the version of backend
Solr, while `solr --version` prints the version of the CLI tool itself. This
probably deserveds its own JIRA...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
