janhoy commented on code in PR #3254: URL: https://github.com/apache/solr/pull/3254#discussion_r3051282807
########## solr/core/src/java/org/apache/solr/cli/StartCommand.java: ########## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cli; + +import java.util.concurrent.Callable; +import picocli.CommandLine; + [email protected]( + name = "start", + description = "Starts Solr in standalone or SolrCloud mode.", + mixinStandardHelpOptions = true) Review Comment: The `mixinStandardHelpOptions` automatically adds both `--help` and `--version` support. However, I'm not sure how useful it is to have `--version` for every single sub command, as we do not release those independently. I think it is enough to have it on top level `solr --version`. My concern is mainly that that extra line adds noise to every single `--help` output. Unfortunately you cannot remove it easily without also removing `--help`, so the solution will be to set this option to `false` and instead provide a `--help` option as a MixIn on the `ToolBase` class. Thoughts @epugh ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
