ercsonusharma commented on code in PR #4276:
URL: https://github.com/apache/solr/pull/4276#discussion_r3110321642
##########
solr/core/src/test/org/apache/solr/handler/component/CombinedQuerySolrCloudTest.java:
##########
@@ -319,17 +319,17 @@ public void testQueriesWithFacetAndHighlightsCollapse()
throws Exception {
}""";
handle.put("expanded", UNORDERED);
QueryResponse rsp = query(CommonParams.JSON, jsonQuery, CommonParams.QT,
"/search");
- assertEquals(1, rsp.getResults().size());
- assertFieldValues(rsp.getResults(), id, "2!2");
+ assertEquals(3, rsp.getResults().size());
Review Comment:
Yeah. Have made another change as my previous attempt didn’t work as I
misinterpreted the failure message and unable to reproduce locally. The main
reason was the inconsistent document routing across 2 shards. There are three
group heads after collapse query ending up any two group heads on one shard and
one remaining on other shard. The final result ordering after rrf was different
than expected in one of a case.
Example - sorted doc order - (0,1,2)
Case 1 : q1 - doc(0,1) and q2 - doc(2) Post rrf - doc(0,2,1)
Case 2 : q1 - doc(0,2) and q2 - doc(1) Post rrf - doc(0,1,2)
As a fix, I have colocated all the docs on same shard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
