janhoy opened a new pull request, #4318:
URL: https://github.com/apache/solr/pull/4318
I noticed that the PR check workflow queue was very long, and that a new
commit to a PR would not cancel the queued checks for previous commits. This
wastes resources and causes longer delay before e.g. Crave.io will test new
PRs, since it is doing work noone cares about.
This PR adds a `concurrency` block to all 9 PR-triggered GitHub Actions
workflows, so that when a new commit is pushed to a PR, any previously queued
or in-progress runs for that same PR are automatically cancelled.
```yaml
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
cancel-in-progress: true
```
The group key is scoped per workflow + PR number, so cancellation is
isolated: a new commit to PR #123 only cancels other runs of the *same
workflow* for PR #123 — it does not affect other PRs or other workflows.
## Workflows updated
All 9 PR-triggered workflows:
- `bin-solr-test.yml`
- `docker-test.yml`
- `gradle-extraction-check.yml`
- `gradle-precommit.yml`
- `labeler.yml`
- `renovate-changelog.yml`
- `solrj-test.yml`
- `tests-via-crave.yml` ← most impactful (Crave.io, 30+ min runs)
- `validate-changelog.yml`
## Impact
Without this change, every commit to a PR queues a fresh run of every
workflow while old runs continue to hold resources. The Crave.io queue in
particular can accumulate dozens of stale runs per active branch, adding hours
of unnecessary wait time for everyone. With this change, only the run for the
latest commit matters — older ones are cancelled
automatically by GitHub Actions before they consume any resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
