Copilot commented on code in PR #4318:
URL: https://github.com/apache/solr/pull/4318#discussion_r3123327151
##########
.github/workflows/tests-via-crave.yml:
##########
@@ -5,6 +5,10 @@ on:
branches:
- '*'
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
Review Comment:
With `cancel-in-progress: true`, an in-progress Crave run will be cancelled
on new commits. GitHub Actions cancels the job immediately and does not execute
later steps, so the current `Cleanup` step is unlikely to run for cancelled
jobs. That can leave behind Crave clones/containers for cancelled runs, which
is the opposite of the intended resource savings. Consider making cleanup
resilient to cancellation (e.g., perform create+build+cleanup in a single
script that installs a SIGTERM/EXIT trap, or use a PR-scoped workspace so the
next run can reliably destroy previous resources for the PR before starting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
