epugh commented on code in PR #4326:
URL: https://github.com/apache/solr/pull/4326#discussion_r3130493457
##########
solr/modules/langid/src/test/org/apache/solr/update/processor/LangDetectLanguageIdentifierUpdateProcessorFactoryTest.java:
##########
@@ -22,11 +22,15 @@
public class LangDetectLanguageIdentifierUpdateProcessorFactoryTest
extends LanguageIdentifierUpdateProcessorFactoryTestCase {
+
@Override
protected LanguageIdentifierUpdateProcessor
createLangIdProcessor(ModifiableSolrParams parameters)
throws Exception {
return new LangDetectLanguageIdentifierUpdateProcessor(
- _parser.buildRequestFrom(h.getCore(), parameters, null), resp, null);
+ _parser.buildRequestFrom(h.getCore(), parameters, null),
Review Comment:
I always disliked the `_` pattern, maybe we can finally eradicate it here?
Totally onboard if that is "out of scope".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
