epugh commented on code in PR #4326:
URL: https://github.com/apache/solr/pull/4326#discussion_r3130503973
##########
solr/modules/langid/src/test/org/apache/solr/update/processor/LangDetectLanguageIdentifierUpdateProcessorFactoryTest.java:
##########
@@ -37,8 +41,22 @@ protected SolrInputDocument tooShortDoc() {
return doc;
}
- /* we don't return 'un' for the super-short one (this detector things
hungarian?).
- * replace this with japanese
+ /**
+ * Override the base class test with LangDetect-specific text samples.
+ *
+ * <p>Two differences from the base class:
+ *
+ * <ul>
+ * <li>The "too short" test case is replaced with Japanese (this detector
returns Hungarian for
+ * short ambiguous text rather than "un").
+ * <li>The Russian text is replaced with a cleaner Cyrillic-only sample.
The base class uses a
Review Comment:
Do we need all this commenting? It's absolutely wonderful while I am
reading the PR, but once committed, it will be confusing. So maybe remove
before merge?
Someday we can have comments in the code that live just for the branch..
and comments that live permenently ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
