epugh commented on code in PR #4178:
URL: https://github.com/apache/solr/pull/4178#discussion_r3142250909
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##########
@@ -152,20 +150,9 @@ public void uninstall(String packageName, String version)
// Delete the package by calling the Package API and remove the Jar
printGreen("Executing Package API to remove this package...");
- PackagePayload.DelVersion del = new PackagePayload.DelVersion();
- del.version = version;
- del.pkg = packageName;
-
- V2Request req =
- new V2Request.Builder(PackageUtils.PACKAGE_PATH)
- .forceV2(true)
- .withMethod(SolrRequest.METHOD.POST)
- .withPayload(Collections.singletonMap("delete", del))
- .build();
-
try {
- V2Response resp = req.process(solrClient);
- printGreen("Response: " + resp.jsonStr());
+ new PackageApi.DeletePackageVersion(packageName,
version).process(solrClient);
+ printGreen("Package version deleted from Package API.");
Review Comment:
humm, not sure I understand based on the diff? DId we eliminate a printing
out? I think we get an exception and then it gets thrown and eventually will
bubble up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
