openworld-maker commented on code in PR #4215:
URL: https://github.com/apache/solr/pull/4215#discussion_r3144306835
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCase.java:
##########
@@ -148,6 +149,28 @@ public static void beforeSolrTestCase() {
ExternalPaths.DEFAULT_CONFIGSET);
}
+ final String allowPaths =
EnvUtils.getProperty(CoreContainer.ALLOW_PATHS_SYSPROP);
Review Comment:
Thanks for the nudge here. I followed up on David's concern by removing the
helper from entirely and setting it only in the tests that need external
configsets. Also removed the framework-level test that only validated the old
default behavior. Revalidated with full in Docker (JDK 21), passing on commit .
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCase.java:
##########
@@ -148,6 +149,28 @@ public static void beforeSolrTestCase() {
ExternalPaths.DEFAULT_CONFIGSET);
}
+ final String allowPaths =
EnvUtils.getProperty(CoreContainer.ALLOW_PATHS_SYSPROP);
Review Comment:
Thanks for the nudge here. I followed up on David's concern by removing the
ALLOW_PATHS_SYSPROP helper from SolrTestCase entirely and setting it only in
the tests that need external configsets. I also removed the framework-level
test that only validated the old default behavior. Revalidated with full
./gradlew --no-daemon precommit in Docker (JDK 21), passing on commit
0161fb70dd1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
