openworld-maker commented on PR #4215: URL: https://github.com/apache/solr/pull/4215#issuecomment-4323238619
Addressed the remaining review concern and pushed commit 0161fb70dd1. What changed: - Removed the global ALLOW_PATHS_SYSPROP behavior from SolrTestCase. - Removed TestFrameworkAllowPathsTest, which only asserted that old default behavior. - Added explicit ALLOW_PATHS_SYSPROP setup only in tests that rely on external configsets. Validation: - Re-ran full precommit in Docker (Temurin JDK 21): ./gradlew --no-daemon precommit - Result: BUILD SUCCESSFUL This keeps the behavior local to the small set of tests that need it, rather than in the base test class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
