janhoy commented on code in PR #2391:
URL: https://github.com/apache/solr/pull/2391#discussion_r3217187756
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -60,7 +65,12 @@ public class ZkContainer {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
protected ZkController zkController;
+
+ // zkServer (and SolrZkServer) wrap a ZooKeeperServerMain if standalone
mode, but in quorum we
+ // just use ZooKeeperServerEmbedded
+ // directly! Why? Can we use ZooKeeperServerEmbedded in one node directly
instead?
private SolrZkServer zkServer;
+ private ZooKeeperServerEmbedded zkServerEmbedded;
Review Comment:
Must be volatile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
