janhoy commented on code in PR #2391:
URL: https://github.com/apache/solr/pull/2391#discussion_r3217566162
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -313,8 +413,37 @@ public void close() {
zkController.close();
}
} finally {
- if (zkServer != null) {
- zkServer.stop();
+ try {
+ if (zkServer != null) {
+ zkServer.stop();
+ }
+ } finally {
+ if (zkServerEmbedded != null) {
+ try {
+ zkServerEmbedded.close();
+ log.info("Closed embedded ZooKeeper server in quorum mode");
Review Comment:
Close log should come after the wait loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
