DanielRaapDev commented on code in PR #815:
URL: https://github.com/apache/solr-operator/pull/815#discussion_r3349470655
##########
config/crd/bases/solr.apache.org_solrclouds.yaml:
##########
@@ -9889,6 +10395,106 @@ spec:
For the LoadBalancer method, this field is optional
and will only be used when useExternalAddress=true.
If used with the LoadBalancer method, you will need
DNS routing to the LoadBalancer IP address through the url template given above.
type: string
+ gateway:
+ description: |-
+ Gateway defines settings for Kubernetes Gateway API
routing.
+
+ This option is only available when Method=Gateway.
+ The referenced Gateway must already exist and be
managed by your platform team.
+ The Solr Operator only manages the HTTPRoute
resources.
+ properties:
Review Comment:
Why is `hostnames` missing of the
[HTTPRouteSpec](https://gateway-api.sigs.k8s.io/reference/api-spec/main/spec/#httproutespec)?
It is useful to filter listeners of the Gateway.
Suggestion:
```suggestion
properties:
hostnames:
description: |-
Hostnames defines a set of hostnames that
should match against the HTTP Host
header to select a HTTPRoute used to process the request..
type: array
maxItems: 16
items:
description: Hostname is the fully qualified
domain name of a network host.
Hostname can be “precise” which is a domain
name without the terminating dot of a network host (e.g. “foo.example.com”) or
“wildcard”, which is a domain name prefixed with a single wildcard label (e.g.
*.example.com).
type: string
minLength: 1
maxLength: 253
pattern:
'^(\*\.)?[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
