chinmoysahu commented on code in PR #815:
URL: https://github.com/apache/solr-operator/pull/815#discussion_r3351890775
##########
config/crd/bases/solr.apache.org_solrclouds.yaml:
##########
@@ -9889,6 +10395,106 @@ spec:
For the LoadBalancer method, this field is optional
and will only be used when useExternalAddress=true.
If used with the LoadBalancer method, you will need
DNS routing to the LoadBalancer IP address through the url template given above.
type: string
+ gateway:
+ description: |-
+ Gateway defines settings for Kubernetes Gateway API
routing.
+
+ This option is only available when Method=Gateway.
+ The referenced Gateway must already exist and be
managed by your platform team.
+ The Solr Operator only manages the HTTPRoute
resources.
+ properties:
Review Comment:
@DanielRaapDev
The
[hostnames](https://github.com/wwgrainger/solr-operator/blob/gtw-ingress-support/controllers/util/gateway_util.go#L42)
field on the HTTPRoute is actually already being populated, auto-generated
from
[spec.solrAddressability.external.domainName](https://github.com/wwgrainger/solr-operator/blob/gtw-ingress-support/controllers/util/gateway_util.go#L28)
and additionalDomainNames ( GenerateCommonHTTPRoute in gateway_util.go). This
produces the hostname pattern like {prefix}-{cloud}-solrcloud. {domain} which
is also used for status.externalCommonAddress, BackendTLSPolicy fqdn, and what
Solr uses as its external URL.
I've added an additionalHostnames field to SolrGatewayOptions that would
allow users to append extra alias hostnames to the common HTTPRoute so that we
cover the use case of routing additional alias names to the same service.
I did not make this an override because the auto-generated hostnames are
tied to status.externalCommonAddress and BackendTLSPolicy and so replacing them
would create a mismatch between what Solr thinks its address is and what the
Gateway actually routes to. Hope it made sense. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
