jaykay12 commented on code in PR #4610:
URL: https://github.com/apache/solr/pull/4610#discussion_r3523789351
##########
gradle/libs.versions.toml:
##########
@@ -254,7 +254,6 @@ apache-httpcomponents-httpclient = { module =
"org.apache.httpcomponents:httpcli
apache-httpcomponents-httpcore = { module =
"org.apache.httpcomponents:httpcore", version.ref =
"apache-httpcomponents-httpcore" }
apache-httpcomponents-httpmime = { module =
"org.apache.httpcomponents:httpmime", version.ref =
"apache-httpcomponents-httpmime" }
apache-kafka-clients = { module = "org.apache.kafka:kafka-clients",
version.ref = "apache-kafka" }
-apache-kafka-kafka213 = { module = "org.apache.kafka:kafka_2.13", version.ref
= "apache-kafka" }
Review Comment:
<img width="634" height="517" alt="Image"
src="https://github.com/user-attachments/assets/320f1449-ca6c-4d90-bfd4-ca1e2ffec811";
/>
##########
solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/consumer/Util.java:
##########
@@ -88,7 +88,8 @@ public static void printKafkaInfo(String host, String
groupId) {
for (TopicPartition topicPartition : topicPartitions) {
if (topicPartition.topic().equals(topic)) {
long endOffset = consumer.position(topicPartition);
- long committedOffset =
consumer.committed(topicPartition).offset();
Review Comment:
https://github.com/apache/solr/actions/runs/28428066221/job/84235821648 ,
Simply updating the version was giving compilation error.
<img width="1012" height="481" alt="Image"
src="https://github.com/user-attachments/assets/2327ddd2-e6e9-4bc3-a54c-3356a21b5164";
/>
## Evidences for supporting this change:
<img width="789" height="340" alt="Image"
src="https://github.com/user-attachments/assets/939cd879-15bb-4b1f-8bca-918c94f68f7b";
/>
##########
gradle/testing/randomization/policies/solr-tests.policy:
##########
@@ -274,6 +274,11 @@ grant codeBase "file:${gradle.worker.jar}" {
permission java.security.AllPermission;
};
+// Global override for local integration testing
+grant {
+ permission java.security.AllPermission;
+};
+
Review Comment:
[pending-to-discuss] with reviewer on the right way here. This works, but
this is not the right way.
This is required to resolve this error, which comes in the cross-dc-manager
test which interacts with the kafka container which runs on docker daemon.
<img width="1362" height="485" alt="Image"
src="https://github.com/user-attachments/assets/d01cef35-915a-4e03-a04f-107296559983";
/>
##########
gradle/libs.versions.toml:
##########
@@ -519,5 +517,6 @@ swagger3-annotations-jakarta = { module =
"io.swagger.core.v3:swagger-annotation
swagger3-jaxrs2-jakarta = { module =
"io.swagger.core.v3:swagger-jaxrs2-jakarta", version.ref = "swagger3" }
tdunning-tdigest = { module = "com.tdunning:t-digest", version.ref =
"tdunning-tdigest" }
testcontainers = { module = "org.testcontainers:testcontainers", version.ref =
"testcontainers" }
+testcontainers-kafka = { module = "org.testcontainers:testcontainers-kafka",
version.ref = "testcontainers" }
Review Comment:
<img width="631" height="307" alt="Image"
src="https://github.com/user-attachments/assets/247971d4-7f23-44f0-aab5-e498ba602d05";
/>
Since Kafka 4.x fully supports lightweight, fast KRaft startups, the
cleanest modern approach is to spin up an ephemeral Docker container using
Testcontainers. It completely isolates Kafka from the JVM running Solr.
[Industry standards]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
