epugh commented on code in PR #4610:
URL: https://github.com/apache/solr/pull/4610#discussion_r3798952208
##########
solr/cross-dc-manager/src/test/org/apache/solr/crossdc/manager/DeleteByQueryToIdTest.java:
##########
@@ -94,16 +100,16 @@ public static void beforeSolrAndKafkaIntegrationTest()
throws Exception {
Properties config = new Properties();
- kafkaCluster =
- new EmbeddedKafkaCluster(NUM_BROKERS, config) {
- @Override
- public String bootstrapServers() {
- return super.bootstrapServers().replaceAll("localhost",
"127.0.0.1");
- }
- };
- kafkaCluster.start();
+ kafkaContainer = new
KafkaContainer(DockerImageName.parse("apache/kafka:4.3.1"));
Review Comment:
is this how we handle other test containers in Solr? Any other patterns
that we *should* be using from other places in Solr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
