markrmiller commented on PR #7:
URL: https://github.com/apache/solr/pull/7#issuecomment-4884063663
Updated this branch with the latest review fixes in `4a44de0c8b5`.
What changed:
- Removed the `TextField` path-hierarchy Lucene 9 compatibility shim; field
queries now use the analyzer's Lucene 10 positions directly.
- Removed LTR shared-executor ownership/plumbing from `LTRThreadModule`,
`LTRQParserPlugin`, and the feature logger transformer; LTR no longer shuts
down or depends on the recovery executor.
- Made `LTRScoringQuery` EFI hashing order-independent and removed remaining
compatibility wording in touched code.
- Replaced LB timeout message-prefix handling with a typed
`LBSolrClient.TimeAllowedExceededException`, while keeping structured/remote
timeout detection in `SearchHandler`.
- Restored public multi-collection/alias request paths in
`AliasIntegrationTest` instead of manually building `shards`.
- Fixed multi-collection shard rewrite to avoid mutating original params and
to preserve request subtype content writers/streams (including JSON query
requests) via a delegating wrapper instead of cloning into a plain
`QueryRequest`.
- Propagated resolved path aliases into request params in `HttpSolrCall` so
direct HTTP collection-list/alias paths reach distributed search correctly.
Verification on Java 25:
- `./gradlew --no-daemon :solr:core:test --tests
org.apache.solr.cloud.AliasIntegrationTest --tests
org.apache.solr.schema.TestTextField --tests
org.apache.solr.handler.component.SearchHandlerTest -Ptests.nightly=true
--console=plain`
- `AliasIntegrationTest`: `tests="9" skipped="0" failures="0" errors="0"`
- `TestTextField`: `tests="2" skipped="0" failures="0" errors="0"`
- `SearchHandlerTest`: `tests="5" skipped="0" failures="0" errors="0"`
- `./gradlew --no-daemon :solr:solrj:test --tests
org.apache.solr.client.solrj.impl.LBSolrClientTest --console=plain`
- `LBSolrClientTest`: `tests="6" skipped="0" failures="0" errors="0"`
- `./gradlew --no-daemon :solr:contrib:ltr:test --tests
org.apache.solr.ltr.TestLTRScoringQuery --tests
org.apache.solr.ltr.TestParallelWeightCreation --console=plain`
- `TestLTRScoringQuery`: `tests="10" skipped="0" failures="0" errors="0"`
- `TestParallelWeightCreation`: `tests="2" skipped="2" failures="0"
errors="0"` (assumption-gated skip)
- `./gradlew --no-daemon :solr:solrj:compileJava --console=plain`
- `git diff --check`
Not rerun in this final pass: full clean test and full nightly core suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
