markrmiller commented on PR #7: URL: https://github.com/apache/solr/pull/7#issuecomment-4887443833
Addressed the latest review in `49411be37d4`. What changed: - Deleted the remaining prefix-coded numeric legacy utility: `PrefixCodedNumericUtils`. - Removed `FieldCache.PREFIX_CODED_*_PARSER` and `UninvertingReader.Type.PREFIX_CODED_*` plus their switch paths. - Removed the prefix-coded test helper and rewrote/pruned uninverting tests so they no longer preserve trie/prefix-coded numeric behavior. - Replaced MLT numeric-id term construction with field-type query creation. - Removed `VersionInfo`'s non-point indexed-term max-version path; indexed versions now use points, otherwise the existing docValues path is used. - Documented the LTR per-request virtual-thread executor cancellation caveat. Verification: - `JAVA_HOME=/usr/lib/jvm/java-25-openjdk-amd64 ./gradlew :solr:core:compileJava :solr:core:compileTestJava -Pvalidation.git.failOnModified=false` PASS - `:solr:core:test --tests org.apache.solr.uninverting.TestUninvertingReader --tests org.apache.solr.uninverting.TestDocTermOrds --tests org.apache.solr.uninverting.TestFieldCacheSort --tests org.apache.solr.search.function.TestOrdValues` PASS: 56 tests, 2 skipped - MLT targeted tests PASS: 21 tests, 9 skipped - `VersionInfoTest` PASS: 2 tests - core forbidden-apis + LTR compile/targeted tests PASS - `JAVA_HOME=/usr/lib/jvm/java-25-openjdk-amd64 ./gradlew check --no-parallel -Pvalidation.git.failOnModified=false && git diff --check` PASS / BUILD SUCCESSFUL Architect verification: APPROVED. No remaining `PREFIX_CODED`, `PrefixCodedNumericUtils`, `PrefixCodedFields`, or `prefix-coded` refs under `solr/core/src/java` or `solr/core/src/test`. Not run: nightly/beast stress pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
