serhiy-bzhezytskyy commented on PR #4612: URL: https://github.com/apache/solr/pull/4612#issuecomment-4911568818
Looked them over — all good. The opt-in `analyzeDependencies` task is better than wiring it into `check`, agree; the advice needs a human looking at it, not a gate. Docs read well too, and nice catch on the spotless lockfile configs. And yeah — fine to drop 2 and 3. 1 is the one worth landing. The project() promotions in 2 were minor and 3 was only ever illustrative, so no loss. Thanks for jumping in on this. (CI red is the flaky `TestGracefulJettyShutdown` — passes locally, unrelated to the diff.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
