serhiy-bzhezytskyy commented on code in PR #4612:
URL: https://github.com/apache/solr/pull/4612#discussion_r3537113710
##########
gradle/validation/dependencies.gradle:
##########
@@ -113,7 +113,8 @@ allprojects {
// This may not be the case where this task is added as a dependency,
like for "dependencies" task
project.configurations.findAll {
// Add any custom filtering on the configurations to be resolved
- it.canBeResolved
+ it.canBeResolved &&
+ !it.attributes.keySet().any {attr ->
attr.name.startsWith("dagp.")}
Review Comment:
Added, thanks.
##########
solr/solrj-jetty/build.gradle:
##########
Review Comment:
Done — removed the self-referential `testImplementation project(':self')` in
api, solrj, solrj-streaming, solrj-zookeeper, and core. Two still had the old
`// cutterslade requires we state the obvious` comment, so those workarounds
are gone with it.
##########
gradle/validation/dependency-analyze.gradle:
##########
Review Comment:
Done — converted it to `.gradle.kts`. buildHealth still runs and the
suppressions all work.
##########
solr/core/build.gradle:
##########
@@ -83,31 +80,25 @@ dependencies {
implementation libs.apache.lucene.sandbox
implementation libs.apache.lucene.spatialextras
implementation libs.apache.lucene.suggest
-
// Collections & lang utilities
implementation libs.google.guava
implementation libs.apache.commons.lang3
implementation libs.apache.commons.math3
implementation libs.commonsio.commonsio
implementation libs.carrotsearch.hppc
-
- implementation(libs.benmanes.caffeine) {transitive = false}
+ api(libs.benmanes.caffeine) {transitive = false}
Review Comment:
Yeah, makes sense. These are in #4614 if it's ever worth revisiting which
deserve an api contract. Thanks.
##########
solr/core/build.gradle:
##########
@@ -121,40 +112,37 @@ dependencies {
testImplementation(libs.apache.curator.test, {
exclude group: 'org.apache.zookeeper', module: 'zookeeper'
})
- implementation(libs.apache.zookeeper.zookeeper, {
+ api(libs.apache.zookeeper.zookeeper, {
exclude group: "org.apache.yetus", module: "audience-annotations"
})
- implementation(libs.apache.zookeeper.jute) {
+ api(libs.apache.zookeeper.jute) {
Review Comment:
Ah, my bad — misread that as ZK. Checked jute: the jar's a bit odd, it also
ships `org.apache.zookeeper.data.*`, and core does expose `Stat` (`getStat()`
returns it). So technically leaked, but agree it's niche. Left as
implementation here anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
