serhiy-bzhezytskyy commented on code in PR #4640:
URL: https://github.com/apache/solr/pull/4640#discussion_r3700109843


##########
solr/solrj/src/test/org/apache/solr/client/solrj/response/AdminResponseNumericTypeTest.java:
##########


Review Comment:
   Randomized `wt` in `TestSuggesterResponse` — it already randomized 
javabin/xml for SOLR-15070, so this adds the JSON parser to that. Removed 
`QueryResponseCrossFormatTest`.
   
   `SolrExampleTests` has a subclass per parser and JSON was missing, so 
`SolrExampleJsonMapTest` now runs all 42 against `JsonMapResponseParser`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to