dsmiley commented on code in PR #4640: URL: https://github.com/apache/solr/pull/4640#discussion_r3708821229
########## solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSuggesterResponse.java: ########## Review Comment: thanks for this. It's good. However, note that most of Lucene & Solr's randomized testing is done at a deeper level such that an individual test generally doesn't even have to do anything to get the randomization -- it just happens at a deeper test framework/infra level. For example... imagine if the default was a settable static supplier... and imagine if SolrTestCase were to set it. Then the useful test coverage would go through the roof (thousands of Solr tests) and we'd probably toss aside more of your tests as redundant. I'm hesitant to truly recommend precisely this... but I'm at least taking the educational opportunity of sharing the rather unique randomized testing philosophy that permeates the Lucene & Solr projects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
