gerlowskija commented on code in PR #4699:
URL: https://github.com/apache/solr/pull/4699#discussion_r3715071608
##########
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java:
##########
@@ -598,18 +600,22 @@ protected void commit() throws Exception {
}
}
+ protected QueryResponse queryRandomShard(ModifiableSolrParams params)
+ throws SolrServerException, IOException {
+ return queryRandomShard(params.get(CommonParams.QT, "/select"), params);
+ }
+
/**
* Queries a random shard; nothing more.
*
* <p>WARNING: tests should generally not call this as it doesn't compare to
the control client
*/
- protected QueryResponse queryRandomShard(ModifiableSolrParams params)
+ protected QueryResponse queryRandomShard(String requestHandler,
ModifiableSolrParams params)
Review Comment:
The ModifiableSolrParams usage pre-exists this PR; it's not something this
PR introduces. For scope reasons I'm a little leery of bogging down the qt
effort in other unrelated refactors unless you feel especially strongly?
(See my PR-level comment asking a similar question.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
