gerlowskija commented on code in PR #4699:
URL: https://github.com/apache/solr/pull/4699#discussion_r3717317213
##########
solr/core/src/test/org/apache/solr/handler/admin/LukeRequestHandlerDistribTest.java:
##########
@@ -61,7 +60,7 @@ private LukeResponse requestLuke(ModifiableSolrParams extra)
throws Exception {
handle.put(LukeRequestHandler.KEY_DISTINCT, SKIP);
handle.put(LukeRequestHandler.KEY_TOP_TERMS, SKIP);
handle.put(LukeRequestHandler.KEY_HISTOGRAM, SKIP);
- QueryResponse qr = query(params);
+ QueryResponse qr = query("/admin/luke", params);
Review Comment:
This `query()` method *is* using QueryRequest/QueryResponse, but it's also
doing a bunch of additional stuff. It runs both a distrib and non-distrib copy
of the request and compares the responses, has a weird "stress" section that
fires off requests in parallel threads, etc. The name makes it sound like an
`assertQ` equivalent, but it's a lot more than that, so doing a LukeRequest
replacement isn't all that quick of a drop-in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
