dsmiley commented on code in PR #4773:
URL: https://github.com/apache/solr/pull/4773#discussion_r3817671458
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -1993,6 +1993,11 @@ public static void verbose(Object... args) {
/**
* Get the request handler registered to a given name.
*
+ * <p>A {@code null} handlerName resolves to the core's default request
handler (whichever handler
+ * is aliased to the empty string, normally the one registered at "/select",
or "standard" for
Review Comment:
@epugh I recall you killed the "standard" pattern
##########
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##########
@@ -3002,10 +3015,12 @@ protected long getIndexVersion(Replica replica) throws
IOException {
.withDefaultCollection(replica.getCoreName())
.build()) {
ModifiableSolrParams params = new ModifiableSolrParams();
- params.set("qt", "/replication");
params.set(ReplicationHandler.COMMAND,
ReplicationHandler.CMD_SHOW_COMMITS);
try {
- QueryResponse response = client.query(params);
Review Comment:
another one bites the dust; thanks
##########
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##########
@@ -2179,6 +2180,18 @@ void doQuery(String expectedDocs, String... queryParams)
throws Exception {
assertEquals(expectedIds, obtainedIds);
}
+ void doQuery(List<String> expectedIds, String path, String... queryParams)
throws Exception {
Review Comment:
I very much disklike the param structure. Can you please require a
QueryRequest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
