gerlowskija commented on code in PR #4773:
URL: https://github.com/apache/solr/pull/4773#discussion_r3820592596
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -1993,6 +1993,11 @@ public static void verbose(Object... args) {
/**
* Get the request handler registered to a given name.
*
+ * <p>A {@code null} handlerName resolves to the core's default request
handler (whichever handler
+ * is aliased to the empty string, normally the one registered at "/select",
or "standard" for
Review Comment:
Yeah, I wasn't sure what "standard" really connoted in our code, but we
still look for it in a few places. So if it was supposed to be removed,
there's still some traces of it around. (That's why I referenced it here.)
I had no idea of the "default request handler" concept; I just kindof
stumbled upon it when trying to figure out why
`SolrCore.getRequestHandler(null)` didn't blow up spectacularly like I would've
expected.
IMO that's a feature that's probably outlived its usefulness and that is
similarly risky from a security perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
