serhiy-bzhezytskyy opened a new pull request, #4778: URL: https://github.com/apache/solr/pull/4778
https://issues.apache.org/jira/browse/SOLR-18390 Removes the four `@Deprecated` test-framework HTTP client convenience helpers (`SolrTestCaseJ4.getHttpSolrClient` overloads and `JettySolrRunner.newClient()`) and inlines every call site to the equivalent `HttpJettySolrClient.Builder` construction -- matching what the deprecated methods' own bodies did. Test-only change, no changelog. 84 files, 173 call sites migrated. While migrating, found and fixed a subtle bug the mechanical inlining would otherwise have introduced: several sites called `Slice.getLeader()` twice (once for the URL, once for the collection name). For PRS collections `getLeader()` recomputes the leader on every call, so calling it twice could return two different replicas if the leader changed in between. Fixed by capturing it once. Ran the highest call-site-density test classes plus everything touched by the getLeader() fix, all green (0 failures): FullSolrCloudDistribCmdsTest, AliasIntegrationTest, TestCoordinatorRole, LB2SolrClientTest, TestPullReplica (nightly), TestPullReplicaErrorHandling, TestPullReplicaWithAuth, TestTlogReplica, HealthCheckHandlerTest, MultiAuthPluginTest, BasicAuthIntegrationTest, HttpSolrClientBadInputTest, TestJettySolrRunner, BasicDistributedZkTest, BasicDistributedZk2Test. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
