epugh commented on PR #4778: URL: https://github.com/apache/solr/pull/4778#issuecomment-5379796880
@dsmiley I think we need your eyes here. I thought this was going to be a more "oh wow, that is so much nicer" type of impact when I looked at the changelog. More "oh yes, the tests are more readable, more compact" and I didn't get that. The migration isn't bad per se, i see the removeal of the deprecated convenience helpers. Maybe I evern liek the less obfuscation of what is going on... However, didn't you have some thoughts about providing the client via TestRule or other ideas that maybe would be a fit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
