serhiy-bzhezytskyy opened a new pull request, #4780: URL: https://github.com/apache/solr/pull/4780
https://issues.apache.org/jira/browse/SOLR-18360 Un-deprecates `HttpJettySolrClient.addListenerFactory(HttpListenerFactory)` instead of removing it. `PKIAuthenticationPlugin` needs it to attach a listener to clients that are already built and already referenced elsewhere by the time security wiring runs: ```java // HttpShardHandlerFactory's constructor: this.defaultClient = new HttpJettySolrClient.Builder()...build(); this.loadbalancer = new LBJettySolrClient.Builder(defaultClient).build(); // captures defaultClient here // CoreContainer.setupHttpClientForAuthPlugin, called later (and again on security.json hot-reload): shardHandlerFactory.setSecurityBuilder(pkiAuthenticationSecurityBuilder); // -> defaultClient.addListenerFactory(...) ``` Rebuilding `defaultClient` via the Builder instead would leave `loadbalancer` pointing at the old, listener-less client -- the security listener would silently never fire on the path that actually routes inter-node requests. Migrated the one call site that was pure construction-time convenience (`HttpShardHandlerFactory`'s own `defaultClient`) to `Builder.addListenerFactory`. No changelog (un-deprecation, not a removal). 50 tests, 0 failures. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
