dsmiley commented on code in PR #4780:
URL: https://github.com/apache/solr/pull/4780#discussion_r3853177951
##########
solr/core/src/java/org/apache/solr/security/HttpClientBuilderPlugin.java:
##########
@@ -26,5 +26,6 @@
*/
public interface HttpClientBuilderPlugin {
- public default void setup(HttpJettySolrClient client) {}
+ /** May be called more than once; each call replaces the previous listener,
not adds to it. */
+ public default void setup(MutableListenerFactory listenerFactory) {}
Review Comment:
If someone is writing a HttpClientBuilderPlugin, maybe this setup method
should expose the HttpJettySolrClient? On the other hand, if the client
instance is really many/variable but they all share a MutableListenerFactory
then it'd be the wrong design. Yeah ... just speaking out loud.
CC @gerlowskija @janhoy the change proposed here changes our API for
customizing HttpClientBuilder. It's labeled "lucene.experiment" so I suppose
we can change at-will but I want to raise attention on this. It will belong in
the changelog.
##########
solr/solrj-jetty/src/java/org/apache/solr/client/solrj/jetty/MutableListenerFactory.java:
##########
Review Comment:
nice documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
