Copilot commented on code in PR #4793: URL: https://github.com/apache/solr/pull/4793#discussion_r3833561680
########## solr/licenses/README.committers.txt: ########## @@ -27,6 +27,12 @@ change across versions of the dependency, so when updating be SURE to update them to the recent version. This also allows others to see what changed with respect to licensing in the commit diff. +LICENSE/NOTICE files are only required for jars that ship in the binary +distribution (runtime dependencies of the server, modules and +cross-dc-manager). Checksum (.sha1) files are required for all dependencies, Review Comment: This description omits `start.jar`, which is not a server runtime dependency but is explicitly included in `distJarValidation` in `solr/server/build.gradle:89`. Please mention it so maintainers do not treat its LICENSE/NOTICE files as unreferenced. ########## dev-docs/gradle-help/dependencies.txt: ########## @@ -227,6 +227,13 @@ missing and where: gradlew licenses +Checksum files (.sha1) are required for every dependency, including test-only +and compile-only ones. LICENSE and NOTICE files are only required for +dependencies that ship in the binary distribution, i.e. the runtime +dependencies of the server, the modules and the cross-dc-manager (SOLR-15465). Review Comment: The list of shipped dependencies is incomplete: `start.jar` is separately packaged and added to `distJarValidation` in `solr/server/build.gradle:89`, but it is not part of `runtimeClasspath`. Please document that exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
