janhoy opened a new pull request, #4803: URL: https://github.com/apache/solr/pull/4803
https://issues.apache.org/jira/browse/SOLR-18400 When metrics collection is disabled, `MetricsHandler` adds an `error` entry instead of `metrics`, and `PrometheusResponseWriter` threw `IOException("No metrics found in response")` → HTTP 500 and a blank Plugins screen. - `PrometheusResponseWriter` now writes the error as a Prometheus comment (`# metrics collection is disabled`) with HTTP 200 — matching the old JSON-era behavior and keeping the response a valid exposition - Plugins screen shows an explanatory message instead of a blank page - New regression test `TestPrometheusResponseWriterMetricsDisabled` (cloud cluster, metrics off by default) Verified with the Selenium Admin UI tests (SmokeTest + CollectionScreensTest, 11 tests) from the `admin-ui-selenium-tests` branch merged locally, and `gradlew precommit`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
