epugh commented on PR #4803: URL: https://github.com/apache/solr/pull/4803#issuecomment-5395969627
> Note: the v2 metrics API (`GetMetrics`) still throws a 510 `INVALID_STATE` error when metrics collection is disabled, so v1 and v2 now behave differently (v1 returns 200 with a `# metrics collection is disabled` comment). I left v2 as-is since this PR targets the v1 endpoint the Admin UI uses, but we may want to align v2 with the same graceful behavior in a follow-up. It would make life easier when we move if V2 did the same as V1... One reason I'm axinous to get us to V2 everywhere we can is that we've seen this pattern of fixes making it to V1 when we also have V2, and then it falls behind... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
