serhiy-bzhezytskyy commented on PR #4811: URL: https://github.com/apache/solr/pull/4811#issuecomment-5435017941
On ContentStream's location: you already answered this yourself on SOLR-18116 back in Feb -- "the server needs to pull the data from the client... All servers have a pull model." That's still the blocker, plus moving the class into solr-core would mean SolrJ's own public write API (`addContentStream`, `setUploadStream`, `toContentStreams`) takes a type from a module that depends on SolrJ, not the reverse. Mikhail hit the same wall trying this in SOLR-11657 (2019) -- EmbeddedSolrServer, the HTTP clients enumerating streams. On multi-part: not theoretical -- ManifoldCF hit a production blocker in 2018 (SOLR-12798) when params exceeded URL limits and multipart was the fix; an independent user (Christian Beikov) hit the same wall in 2020. That's exactly what SOLR-12843 added multipart support for in the first place -- this PR just carries it forward through the ContentStream->ContentWriter migration. Dropping it would regress a real, previously-reported problem, not just an unused code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
