epugh commented on code in PR #4744:
URL: https://github.com/apache/solr/pull/4744#discussion_r3879964271
##########
solr/modules/cross-dc/src/java/org/apache/solr/crossdc/common/ConfigProperty.java:
##########
@@ -49,10 +43,6 @@ public boolean isRequired() {
return required;
}
- public String getDefaultValue() {
Review Comment:
My sense on that is YAGNI: You Ain't Going to Need It. If it was
valuable, there would be tests around it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
