epugh commented on code in PR #4744:
URL: https://github.com/apache/solr/pull/4744#discussion_r3879971711
##########
solr/modules/cross-dc/src/java/org/apache/solr/crossdc/update/processor/MirroringUpdateRequestProcessorFactory.java:
##########
@@ -223,14 +218,6 @@ public void inform(SolrCore core) {
mirroringHandler = new KafkaRequestMirroringHandler(sink);
}
- private static Integer getIntegerPropValue(String name, Properties props) {
Review Comment:
YAGNI ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]