dsmiley commented on PR #4823: URL: https://github.com/apache/solr/pull/4823#issuecomment-5454359291
_ai generated_ this module already has integration tests over the same code path — SimpleSolrIntegrationTest, ZkConfigIntegrationTest, SolrAndKafkaReindexTest — running against a real MiniSolrCloudCluster. They passed throughout. The mock-based tests are the ones that wedged CI, and they're the ones that had to be hand-edited to keep compiling. _(end)_ Makes me question if this module needs mocks in the first place. I hate mocks. But I didn't look with my own eyes closely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
