epugh commented on PR #4823: URL: https://github.com/apache/solr/pull/4823#issuecomment-5454492986
> _ai generated_ > > this module already has integration tests over the same code path — SimpleSolrIntegrationTest, ZkConfigIntegrationTest, SolrAndKafkaReindexTest — running against a real MiniSolrCloudCluster. They passed throughout. The mock-based tests are the ones that wedged CI, and they're the ones that had to be hand-edited to keep compiling. > > _(end)_ > > Makes me question if this module needs mocks in the first place. I hate mocks. But I didn't look with my own eyes closely. I share your sentiment on the Mocks. Many of the tests in this module don't use mocks... I specifically asked about eliminating the all together, and the only reaosn I went with mocks was that when I aske claude about "hey, how do I tickle this specific data scenario with real embedded solr etc" it said it would jump up the test time! I didn't actually try to do that and verify that the test duration would increase.. I'd be open to givign that a stab and just seeing....? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
