sigram commented on code in PR #4744:
URL: https://github.com/apache/solr/pull/4744#discussion_r3882732887
##########
solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/messageprocessor/SolrMessageProcessor.java:
##########
@@ -335,43 +333,6 @@ private void logFirstAttemptLatency(MirroredSolrRequest<?>
mirroredSolrRequest)
}
}
- /**
- * Adds {@link CrossDcConstants#SHOULD_MIRROR}=false to the params if it's
not already specified.
- * Logs a warning if it is specified and NOT set to false. (i.e. circular
mirror may occur)
- *
- * @param mirroredSolrRequest MirroredSolrRequest object that is being
processed.
- */
- void preventCircularMirroring(MirroredSolrRequest<?> mirroredSolrRequest) {
Review Comment:
This is currently handled individually in
MirroringUpdateRequestProcessorFactory and in MirroringCollectionsHandler, but
in both cases the code is much simpler than this method ... so I think we can
drop it for now.
##########
solr/modules/cross-dc/src/java/org/apache/solr/crossdc/common/MirroredSolrRequest.java:
##########
@@ -227,10 +227,6 @@ public long getSubmitTimeNanos() {
return submitTimeNanos;
}
- public void setSubmitTimeNanos(final long submitTimeNanos) {
- this.submitTimeNanos = submitTimeNanos;
- }
-
Review Comment:
You can delete this, this should not be mutable anyway. BTW, the time
tracking is broken anyway (nanos cannot be compared across wire) and needs to
be fixed, I'll file a separate Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
