NextbrickInc commented on PR #4818: URL: https://github.com/apache/solr/pull/4818#issuecomment-5465574031
@janhoy — okay noted. brief status now the three-day window is up. Nothing outstanding on my side. Your three inline comments are answered, and the one that needed a change is in 9b5545ddb4: core-overview.js now names its three known ping states explicitly, so an unrecognised value no longer renders an "enable ping" control that couldn't work. enabled, disabled and not_configured behave as before. Full Admin UI Selenium suite with -Ptests.selenium=true: 53 tests across 18 suites, 0 failures, 0 skipped. gradle check and the Admin UI browser-test workflow are green; the Crave job was cancelled by infrastructure, not a test failure. @epugh — the Schema Designer question is answered above; the fix is deterministic rather than a flake workaround. If you're both happy with it, please approve and merge. Thanks alot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
